Opened 2 years ago

Closed 2 years ago

#155 closed defect (fixed)

Dispvm create should _not_ create appmenus

Reported by: joanna Owned by: marmarek
Priority: major Milestone: Release 1 Beta 1
Component: core Keywords:
Cc:

Description

And currently the appmenus are created in /usr/local/share/applications and they only pollute the Start menu.

Change History (7)

comment:1 Changed 2 years ago by joanna

Can we remove the %{template}-dvm VM after we create the savefile?

It would be ideal, so that we would not need to display this (otherwise useless) VM in the manager (which only confuses the user).

comment:2 Changed 2 years ago by rafal

The current code expects to store certain files in template-dvm directory. So, the quick answer is no.
We could probably remove template-dvm from qubes.xml only. We would have to re-add it before each savefile regeneration (so that qvm-start would work); it is not particularly nice.
The clean solution is to mark template-dvm as special (passing e.g. --dvm-template to qvm-create), and act properly - do not create appmenus for it, and do not show it in the manager. I guess automatically recognizing all VMs whose name end in -dvm is not particularly aesthetic. So, we need another property in qubes.xml ? New class perhaps ? Not sure if it is worth the effort.

comment:3 Changed 2 years ago by joanna

  • Owner changed from joanna to marmarek
  • Status changed from new to assigned

Leaving it as it is now is only asking for troubles -- user *will* click on the appmenus for *-dvm, and some will perhaps even try to remove such VM from the gui-manager (I would probably do it myself!).

So, I think we should implement it now. Leaving this for the next week though.

comment:4 Changed 2 years ago by joanna

  • Priority changed from major to minor

comment:5 Changed 2 years ago by joanna

  • Priority changed from minor to major

comment:6 Changed 2 years ago by marmarek

  • Status changed from assigned to accepted
Note: See TracTickets for help on using tickets.