Opened 21 months ago
Closed 18 months ago
#367 closed defect (fixed)
disable excessive (all) debug output in gui agent and guid
| Reported by: | joanna | Owned by: | marmarek |
|---|---|---|---|
| Priority: | major | Milestone: | Release 1 Beta 3 |
| Component: | gui-virtualization | Keywords: | |
| Cc: |
Description
When using with some programs that often refresh the window bitmaps (e.g. bochs) the amount of debug output printed by gui agent is huge and affects cpu performance significantly.
Besides, it's a usual practice to *not* output debug info, unless started with some option. So, I think we should implement a '--debug' switch for gui agent and gui daemon.
Change History (8)
comment:1 Changed 21 months ago by joanna
comment:2 Changed 21 months ago by marmarek
- Resolution set to fixed
- Status changed from new to closed
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=e3504e339ce59493225af1a96b2fcc6e417ab852
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=a33ff33dd32f16b3027cad9b6478352193099b57
http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=6f50bc4b22e70cb7c5ccf1679e60c5d3a30a3818
comment:3 Changed 18 months ago by joanna
- Resolution fixed deleted
- Status changed from closed to reopened
In pre3 there is still plenty of stuff logged to /var/log/qubes/gui_agent.log -- those should be off by default. Same for Dom0 -- still too much stuff as for the production mode, please disable those by default.
comment:4 Changed 18 months ago by marmarek
- Owner changed from rafal to marmarek
- Status changed from reopened to accepted
Then bugreports will be almost useless.
What specific message do you thing is unneeded for production mode?
comment:5 Changed 18 months ago by joanna
I think that logging of events that are more fine grained that window creation/destroy/manipulation should be disabled. So, events such as key-presses or mouse events, or pixmap updates, etc. So, generally, as far as I don't create, resize, etc, windows, there should not be (almost) anything logged. Currently gui_agents logs lots of stuff, such as move events, which makes the logs very huge BTW.
comment:6 Changed 18 months ago by marmarek
- Resolution set to fixed
- Status changed from accepted to closed
comment:7 Changed 18 months ago by joanna
- Resolution fixed deleted
- Status changed from closed to reopened
Mouse movement events are still being logged, which makes the gui agent log files to be several MB is size, and (I guess) also contribute to increased CPU utilization while scrolling e.g. in PDF files.
comment:8 Changed 18 months ago by marmarek
- Resolution set to fixed
- Status changed from reopened to closed
gui-agent log level was not initialized...
While at it, we should also rename the logs created by guid to something like guid.X.log (currently it is qubes.X.log).