Opened 11 months ago

Closed 11 months ago

#619 closed defect (fixed)

Anonymize/obfuscate "set title for windows" messages in the guid logs

Reported by: joanna Owned by: marmarek
Priority: minor Milestone: Release 1
Component: gui-virtualization Keywords:
Cc: marmarek

Description

This message leaks out private user's data, such as e.g. email subjects (titles for Thunderbirds message windows). e.g."

set title for window 0x340001c to Re: [Qubes] #617: NM icon disappears after resume from S3 sleep
Created 0x3400592(0x1042ac0) parent 0x0(0x131) ovr=1
Created 0x3400594(0x1042ba8) parent 0x0(0x131) ovr=1
Created 0x3400595(0x1042bae) parent 0x0(0x131) ovr=0

Change History (6)

comment:1 Changed 11 months ago by marmarek

But this message is very useful when debugging oneself... Perhaps we want to obfuscate it in qubes-manager just before copying to shared clipboard?

comment:2 Changed 11 months ago by joanna

But the log already contains Windows IDs, and one can always use xwininfo to find out which window it is, including the titlebar.

comment:3 Changed 11 months ago by marmarek

If window still exists...

comment:4 Changed 11 months ago by joanna

If the window doesn't exist and the bug cannot be reproduced, then it's not a ticketable bug :)

Anyway, it's unacceptable to leak user's personal info into logs.

comment:5 Changed 11 months ago by marmarek

  • Owner changed from rafal to marmarek
  • Status changed from new to accepted

comment:6 Changed 11 months ago by marmarek

  • Resolution set to fixed
  • Status changed from accepted to closed

​http://git.qubes-os.org/gitweb/?p=marmarek/gui.git;a=commit;h=3fa8e7e11be79d77af3633a13ec6e42178b9866b

Note: See TracTickets for help on using tickets.